priyeshkaratha commented on code in PR #8251:
URL: https://github.com/apache/ozone/pull/8251#discussion_r2037653908
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -377,15 +402,21 @@ public List<ContainerWithPipeline>
getContainerWithPipelineBatch(
public List<ContainerWithPipeline> getExistContainerWithPipelinesInBatch(
List<Long> containerIDs) {
List<ContainerWithPipeline> cpList = new ArrayList<>();
+ List<Long> succeededContainers = new ArrayList<>();
for (Long containerID : containerIDs) {
try {
ContainerWithPipeline cp = getContainerWithPipelineCommon(containerID);
cpList.add(cp);
+ succeededContainers.add(containerID);
} catch (IOException ex) {
- //not found , just go ahead
- LOG.error("Container with common pipeline not found: {}", ex);
+ AUDIT.logReadFailure(buildAuditMessageForFailure(
+ SCMAction.GET_EXIST_CONTAINER_WITH_PIPELINE_BATCH,
+ Collections.singletonMap("containerID",
String.valueOf(containerID)), ex));
}
}
+ AUDIT.logReadSuccess(buildAuditMessageForSuccess(
+ SCMAction.GET_EXIST_CONTAINER_WITH_PIPELINE_BATCH,
+ Collections.singletonMap("containerIDs",
succeededContainers.toString())));
return cpList;
}
Review Comment:
Thanks @adoroszlai . I have handled it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
