fapifta commented on a change in pull request #2083:
URL: https://github.com/apache/ozone/pull/2083#discussion_r616407582
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/upgrade/BasicUpgradeFinalizer.java
##########
@@ -145,12 +145,14 @@ public StatusAndMessages finalize(String upgradeClientID,
T id)
@Override
public synchronized StatusAndMessages reportStatus(
- String upgradeClientID, boolean takeover
+ String upgradeClientID, boolean takeover, boolean readonly
) throws UpgradeException {
if (takeover) {
clientID = upgradeClientID;
}
- assertClientId(upgradeClientID);
+ if (!readonly) {
+ assertClientId(upgradeClientID);
Review comment:
Hi @guihecheng,
ah, so the use case here is to poll the status from some kind of an
automation as I understand. The proposal sounds reasonable to me, and it is way
more easier than to ensure to properly serve the message queue contents to an
unknown number of concurrent clients, I like it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
