fapifta commented on a change in pull request #2083:
URL: https://github.com/apache/ozone/pull/2083#discussion_r617093228
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/upgrade/TestOMUpgradeFinalizer.java
##########
@@ -188,9 +198,11 @@ public void testFinalizationWithUpgradeAction() throws
Exception {
if (finalizer.isFinalizationDone()) {
when(versionManager.getUpgradeState()).thenReturn(FINALIZATION_DONE);
}
- StatusAndMessages status = finalizer.reportStatus(CLIENT_ID, false);
+ StatusAndMessages status = finalizer.reportStatusAndMsgs(CLIENT_ID, false);
assertEquals(FINALIZATION_DONE, status.status());
assertFalse(status.msgs().isEmpty());
+ Status ret = finalizer.reportStatus();
+ assertEquals(status, ret);
Review comment:
We need to assert equality of status.status(), and ret.
It might be more obvious if we rename the variable status to
finalizerResponse or similar, but this is just an afterthought as I watch my
code, to understand it from afar :) If you are up to do this rename, please
rename the variable in other test methods as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
