bshashikant commented on a change in pull request #2155:
URL: https://github.com/apache/ozone/pull/2155#discussion_r616417617
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/InterSCMGrpcClient.java
##########
@@ -52,13 +52,15 @@
private final InterSCMProtocolServiceGrpc.InterSCMProtocolServiceStub
client;
- private final long timeout;
-
- public InterSCMGrpcClient(final String host, final ConfigurationSource conf)
{
- Preconditions.checkNotNull(conf);
- int port = conf.getInt(ScmConfigKeys.OZONE_SCM_GRPC_PORT_KEY,
- ScmConfigKeys.OZONE_SCM_GRPC_PORT_DEFAULT);
- timeout =
+ public InterSCMGrpcClient(final String host, final int leaderPort,
+ final ConfigurationSource conf) {
+ // if the leader grpc port details are not setup in the peer Map,
+ // fall back to default grpc port.
+ final int port = leaderPort == 0 ?
Review comment:
This is required for tests. With Multiple SCM setups, grpc ports for
individual SCMs will be different. But, grpc client needs to connect leader
grpc port which it does not know from the leaderInfo from Ratis. In actual
production clusters, all grpc servers on all nodes will bind to the same grpc
port which is not possible in MiniOzoneHAcluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
