bharatviswa504 commented on a change in pull request #2155:
URL: https://github.com/apache/ozone/pull/2155#discussion_r616419544
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/InterSCMGrpcClient.java
##########
@@ -52,13 +52,15 @@
private final InterSCMProtocolServiceGrpc.InterSCMProtocolServiceStub
client;
- private final long timeout;
-
- public InterSCMGrpcClient(final String host, final ConfigurationSource conf)
{
- Preconditions.checkNotNull(conf);
- int port = conf.getInt(ScmConfigKeys.OZONE_SCM_GRPC_PORT_KEY,
- ScmConfigKeys.OZONE_SCM_GRPC_PORT_DEFAULT);
- timeout =
+ public InterSCMGrpcClient(final String host, final int leaderPort,
+ final ConfigurationSource conf) {
+ // if the leader grpc port details are not setup in the peer Map,
+ // fall back to default grpc port.
+ final int port = leaderPort == 0 ?
Review comment:
If each SCM is having different Grpc port, it can get leader grpc port
from nodeDetails Right?(It does not need to know this from leader info from
ratis, we can get this from nodeDetails. Not sure If I am missing something
here.
If we have already set grpc port in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
