bshashikant commented on a change in pull request #2155:
URL: https://github.com/apache/ozone/pull/2155#discussion_r618234181
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMSnapshotProvider.java
##########
@@ -103,18 +101,19 @@ public DBCheckpoint getSCMDBSnapshot(String
leaderSCMNodeID)
.getAbsolutePath();
File targetFile = new File(snapshotFilePath + ".tar.gz");
- // the client instance will be initialized only when first install snapshot
- // notification from ratis leader will be received.
- if (client == null) {
- client = new InterSCMGrpcClient(
- peerNodesMap.get(leaderSCMNodeID).getInetAddress().getHostAddress(),
- conf);
- }
+ // the downloadClient instance will be craeted as and when install snapshot
+ // request is received. No caching of the client as it should be a very
rare
+ int port = peerNodesMap.get(leaderSCMNodeID).getGrpcPort();
+ SCMSnapshotDownloader downloadClient = new InterSCMGrpcClient(
+ peerNodesMap.get(leaderSCMNodeID).getInetAddress().getHostAddress(),
+ port, conf);
try {
- client.download(targetFile.toPath()).get();
- } catch (InterruptedException | ExecutionException e) {
+ downloadClient.download(targetFile.toPath()).get();
Review comment:
For now, SCMSnapshotDownloader does not implement the AutoCloseable
interface. Will take it up in refactoring in a subsequent patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
