devmadhuu commented on code in PR #8591:
URL: https://github.com/apache/ozone/pull/8591#discussion_r2136920609
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/OMDBInsightEndpoint.java:
##########
@@ -1305,6 +1305,13 @@ private void createSummaryForDeletedDirectories(
OmTableInsightTask.getTableCountKeyFromTable(DELETED_DIR_TABLE)));
// Calculate the total number of deleted directories
dirSummary.put("totalDeletedDirectories", deletedDirCount);
+
+ // Get all deleted directories without pagination
+ KeyInsightInfoResponse deletedDirInsightInfo = new
KeyInsightInfoResponse();
+ getPendingForDeletionDirInfo(Integer.MAX_VALUE, "", deletedDirInsightInfo);
Review Comment:
This method was developed for a limited page size may be 10, 20 and max 50
records per page. And calling this as part of summary
(`/deletePending/dirs/summary`) API is not feasible with limit of
`Integer.MAX_VALUE`. Summary API was designed to be less computation or time
consuming operation and just pick from pre-computed values as such values are
shown over Recon Overview page. Keeping in mind that scaling issue when large
number of directories are deleted by user from its cluster may create
performance issues. So these both values to be picked from NSSummary. as part
of pre-computed data. Pls explore that part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
