tanvipenumudy commented on code in PR #8591:
URL: https://github.com/apache/ozone/pull/8591#discussion_r2137608119
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/OMDBInsightEndpoint.java:
##########
@@ -1305,6 +1305,13 @@ private void createSummaryForDeletedDirectories(
OmTableInsightTask.getTableCountKeyFromTable(DELETED_DIR_TABLE)));
// Calculate the total number of deleted directories
dirSummary.put("totalDeletedDirectories", deletedDirCount);
+
+ // Get all deleted directories without pagination
+ KeyInsightInfoResponse deletedDirInsightInfo = new
KeyInsightInfoResponse();
+ getPendingForDeletionDirInfo(Integer.MAX_VALUE, "", deletedDirInsightInfo);
Review Comment:
Thank you for the review, as discussed - will be making the following
changes:
- Creating a new endpoint to report the total pending deletion size for FSO
directories. This is to avoid impacting the overview page, which uses the
current endpoint modified.
- Extract the minimal logic for calculation to a separate method excluding
response creation logic, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
