siddhantsangwan commented on code in PR #8663:
URL: https://github.com/apache/ozone/pull/8663#discussion_r2158186845
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/WritableECContainerProvider.java:
##########
@@ -203,8 +203,14 @@ private ContainerInfo allocateContainer(ReplicationConfig
repConfig,
Pipeline newPipeline = pipelineManager.createPipeline(repConfig,
excludedNodes, Collections.emptyList());
+ // the returned ContainerInfo should not be null (due to not enough space
in the Datanodes specifically) because
Review Comment:
Good point. I checked, pipeline will not be null. There's a
`checkPipeline(pipeline)` method that checks for null and throws an exception
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
