siddhantsangwan commented on code in PR #8813:
URL: https://github.com/apache/ozone/pull/8813#discussion_r2229289771
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/ContainerReplicaPendingOps.java:
##########
@@ -59,12 +61,47 @@ public class ContainerReplicaPendingOps {
private ReplicationManagerMetrics replicationMetrics = null;
private final List<ContainerReplicaPendingOpsSubscriber> subscribers =
new ArrayList<>();
+ // tracks how much data is pending to be added to a target Datanode because
of pending ADD ops
+ private final ConcurrentHashMap<DatanodeID, SizeAndTime>
containerSizeScheduled = new ConcurrentHashMap<>();
+ private final long replicationManagerEventTimeout;
- public ContainerReplicaPendingOps(Clock clock) {
+ public ContainerReplicaPendingOps(Clock clock, OzoneConfiguration conf) {
this.clock = clock;
+ ReplicationManager.ReplicationManagerConfiguration rmConf =
+
conf.getObject(ReplicationManager.ReplicationManagerConfiguration.class);
+ replicationManagerEventTimeout = rmConf.getEventTimeout();
Review Comment:
I see. To avoid a circular dependency between `ReplicationManager` and
`ContainerReplicaPendingOps`, I'm now making `StorageContainerManager` create
the `ReplicationManagerConfiguration` object and pass it to
`ReplicationManager` and `ContainerReplicaPendingOps`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
