sumitagrawl commented on code in PR #8813:
URL: https://github.com/apache/ozone/pull/8813#discussion_r2235170609
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/scm/AbstractReconContainerManagerTest.java:
##########
@@ -109,7 +109,7 @@ public void setUp(@TempDir File tempDir) throws Exception {
scmhaManager,
scmContext);
ContainerReplicaPendingOps pendingOps = new ContainerReplicaPendingOps(
- Clock.system(ZoneId.systemDefault()));
+ Clock.system(ZoneId.systemDefault()), conf);
Review Comment:
Need pass ReplicationConf, as then only, reconfigurable will work.
For test case, need have single constructor, but a factory method in
TestModule to be added to avoid changes to testcase frequently with default
value/default mocked value. like ReplicationManager mock or ReplicationManager
with ozone conf re-init.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
