siddhantsangwan commented on code in PR #8813:
URL: https://github.com/apache/ozone/pull/8813#discussion_r2229304872
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/scm/AbstractReconContainerManagerTest.java:
##########
@@ -109,7 +109,7 @@ public void setUp(@TempDir File tempDir) throws Exception {
scmhaManager,
scmContext);
ContainerReplicaPendingOps pendingOps = new ContainerReplicaPendingOps(
- Clock.system(ZoneId.systemDefault()));
+ Clock.system(ZoneId.systemDefault()), conf);
Review Comment:
> These changes can be avoided by overloading the constructor: keeping the
existing one for unrelated tests, and adding the new parameter for prod and
related tests.
Added an overloaded constructor. I think the tradeoff of having multiple
constructors both here and in `ContainerReplicaOp` is that they make things
more complicated in the sense that people using this class in the future have
to figure out which one to use. Also I have to figure out which tests are
related, which prod code is related, which tests are unrelated and so on.
Whereas a single constructor is simple in the sense that the same thing is used
and tested everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
