ChenSammi commented on code in PR #9310:
URL: https://github.com/apache/ozone/pull/9310#discussion_r2540465788
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerConfiguration.java:
##########
@@ -276,22 +276,30 @@ public HddsProtos.DiskBalancerConfigurationProto.Builder
toProtobufBuilder() {
return builder;
}
+ /**
+ * Merges proto configuration into an existing configuration object.
+ * Only fields present in the proto will be updated.
+ *
+ * @param newConfigProto the proto containing fields to update
+ * @param existingConfig the existing configuration to merge into
+ * @return the updated configuration object
+ */
public static DiskBalancerConfiguration fromProtobuf(
Review Comment:
Could you change the name to something like updateFromProtobuf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
