ChenSammi commented on code in PR #9310:
URL: https://github.com/apache/ozone/pull/9310#discussion_r2540775225
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestNodeDecommissionManager.java:
##########
@@ -115,19 +114,19 @@ private ContainerInfo getMockContainer(ReplicationConfig
rep, ContainerID conId)
@Test
public void testHostStringsParseCorrectly()
throws InvalidHostStringException {
- HostDefinition def = new HostDefinition("foobar");
+ NodeDecommissionManager.HostDefinition def = new
NodeDecommissionManager.HostDefinition("foobar");
assertEquals("foobar", def.getHostname());
assertEquals(-1, def.getPort());
- def = new HostDefinition(" foobar ");
+ def = new NodeDecommissionManager.HostDefinition(" foobar ");
assertEquals("foobar", def.getHostname());
assertEquals(-1, def.getPort());
- def = new HostDefinition("foobar:1234");
+ def = new NodeDecommissionManager.HostDefinition("foobar:1234");
assertEquals("foobar", def.getHostname());
assertEquals(1234, def.getPort());
- def = new HostDefinition("foobar.mycompany.com:1234");
+ def = new
NodeDecommissionManager.HostDefinition("foobar.mycompany.com:1234");
Review Comment:
Please revert the changes in this file. It doesn't change anything. We
should avoid unnecessary code changes in commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
