Gargi-jais11 commented on code in PR #9310:
URL: https://github.com/apache/ozone/pull/9310#discussion_r2540830325
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestNodeDecommissionManager.java:
##########
@@ -115,19 +114,19 @@ private ContainerInfo getMockContainer(ReplicationConfig
rep, ContainerID conId)
@Test
public void testHostStringsParseCorrectly()
throws InvalidHostStringException {
- HostDefinition def = new HostDefinition("foobar");
+ NodeDecommissionManager.HostDefinition def = new
NodeDecommissionManager.HostDefinition("foobar");
assertEquals("foobar", def.getHostname());
assertEquals(-1, def.getPort());
- def = new HostDefinition(" foobar ");
+ def = new NodeDecommissionManager.HostDefinition(" foobar ");
assertEquals("foobar", def.getHostname());
assertEquals(-1, def.getPort());
- def = new HostDefinition("foobar:1234");
+ def = new NodeDecommissionManager.HostDefinition("foobar:1234");
assertEquals("foobar", def.getHostname());
assertEquals(1234, def.getPort());
- def = new HostDefinition("foobar.mycompany.com:1234");
+ def = new
NodeDecommissionManager.HostDefinition("foobar.mycompany.com:1234");
Review Comment:
@ChenSammi these changes were necessary since
[NodeUtils.java](https://github.com/apache/ozone/blob/HDDS-5713/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeUtils.java)
was added as part of DiskBalancer changes so now since we don't need this
class for scm and is been removed, as a result of which
`TestNodeDecommissionManager` needed to be changed.
In master it is same as I have done the changes
https://github.com/apache/ozone/blob/b6c742e162fe873e1d90c665ca0880ea743907d0/hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestNodeDecommissionManager.java#L126-L130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
