peterxcli commented on code in PR #9320:
URL: https://github.com/apache/ozone/pull/9320#discussion_r2548831923
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java:
##########
@@ -185,7 +190,12 @@ public OMRequest getLastRequestToSubmit() {
private OMResponse submitReadRequestToOM(OMRequest request)
throws ServiceException {
// Read from leader or followers using linearizable read
- if (omRatisServer.isLinearizableRead()) {
+ if (ozoneManager.isFollowerReadLocalLeaseEnabled() &&
+ allowFollowerReadLocalLease(omRatisServer.getServerDivision(),
Review Comment:
Does omRatisServer.getServerDivision() reflect up-to-date Raft ring state?
We’re using its DivisionInfo to assess follower staleness, so I want to confirm
the freshness guarantees.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java:
##########
@@ -76,6 +76,18 @@ public final class OMConfigKeys {
public static final String OZONE_OM_GRPC_PORT_KEY =
"ozone.om.grpc.port";
+ public static final String OZONE_OM_FOLLOWER_READ_LOCAL_LEASE_ENABLED_KEY =
Review Comment:
I left a comment in
https://github.com/apache/ozone/pull/9222#discussion_r2548829965. Could we
group the read options so users and developers can understand them more easily?
We already have a strictness order in
OzoneManagerProtocolServerSideTranslatorPB, which is part of this change:
```java
if (stale read available) { ... }
else if (follower linearizable read) { ... }
else /* leader-only read */ { ... }
```
How about adding the follower stale read to this set of read options as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
