peterxcli commented on code in PR #9320:
URL: https://github.com/apache/ozone/pull/9320#discussion_r2549231519
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java:
##########
@@ -76,6 +76,18 @@ public final class OMConfigKeys {
public static final String OZONE_OM_GRPC_PORT_KEY =
"ozone.om.grpc.port";
+ public static final String OZONE_OM_FOLLOWER_READ_LOCAL_LEASE_ENABLED_KEY =
Review Comment:
Thanks—yes, I was referring to including follower stale reads within the
read options. Your comment
(https://github.com/apache/ozone/pull/9222#discussion_r2549047542) reminded me
we should also cover fallback behavior. I’m thinking we introduce a clearer,
self-contained set of read modes so users can configure intent without
scattered flags:
1. leader-only-read
2. follower-linearizable-read
3. follower-stale-read-or-fallback-follower-linearizable-read
- Prefer follower stale read; if not possible, fall back to follower
linearizable read
4. follower-stale-read-or-fallback-leader-only-read
- Prefer follower stale read; if not possible, fall back to leader-only
read
These modes make the configuration atomic and avoid scattering multiple
booleans. We should also add comprehensive documentation for each
mode—consistency guarantees, when fallback triggers, and expected performance
implications. The trade-off is that we’ll need a small translation layer to map
these flexible modes to Ratis server settings and to the branching in
OzoneManagerProtocolServerSideTranslatorPB. I’m fine to own that conversion
logic so the config remains clean and self-contained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
