adoroszlai commented on code in PR #9320:
URL: https://github.com/apache/ozone/pull/9320#discussion_r2559875954
##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -2266,6 +2266,33 @@
</description>
</property>
+ <property>
+ <name>ozone.om.follower.read.local.lease.enabled</name>
+ <value>false</value>
+ <tag>OZONE, OM, RATIS, MANAGEMENT</tag>
+ <description> If we enabled the local lease for Follower Read.
+ If enabled, follower OM will decide if return local data directly
+ based on lag log and time.
+ </description>
+ </property>
+ <property>
+ <name>ozone.om.follower.read.local.lease.lag.limit</name>
+ <value>10000</value>
+ <tag>OZONE, OM, RATIS, MANAGEMENT</tag>
+ <description> If the lag between leader OM and follower OM is larger
+ than this number, the follower OM is not up-to-date.
+ </description>
+ </property>
+ <property>
+ <name>ozone.om.follower.read.local.lease.time.ms</name>
+ <value>5000</value>
+ <tag>OZONE, OM, RATIS, MANAGEMENT</tag>
+ <description> If the lag time Ms between leader OM and follower OM is
larger
+ than this number, the follower OM is not up-to-date.
+ By default, it's set to Ratis RPC timeout value.
+ </description>
+ </property>
Review Comment:
I would be nice to introduce these new settings in `OmConfig` (see
HDDS-12298), to avoid further bloating `OzoneManager`. Most importantly it
would eliminate the boilerplate required for making the new properties
reconfigurable to:
https://github.com/apache/ozone/blob/7c53356a5e41499ebc3e7bf67540a24603d0f502/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OmConfig.java#L70
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
