sumitagrawl commented on PR #9351: URL: https://github.com/apache/ozone/pull/9351#issuecomment-3580854574
> it feels like a hack instead of checking the node state (HB) the code is trying to trigger HB on for each GET VERSION which may have side effects when GET VERSION is called outside of register use case. - For other ICR, there is a different thread giving interrupt to HB thread to trigger immediate. - For this case, we can not do interrupt and State can not be exposed -- as defined State -- INIT, Running, Shutdown. Introducing new state is not recommended for next HB to trigger immediate. So updating HB time only is only solution without exposing internal action to HB mechanism, like an interrupt as being implemented for other threads. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
