ivandika3 opened a new pull request, #9383: URL: https://github.com/apache/ozone/pull/9383
## What changes were proposed in this pull request? Currently, reconfiguration implementation calls `OzoneConfiguration#set` in the `ReconfigurableBase#reconfigurePropertyImpl` implementation. However, we should defer setting the configuration field in `ReconfigurationBase#reconfigureProperty`. This will handle issues where there are exceptions during the reconfigurePropertyImpl. Currently, this is fine since most of the reconfigurations are simple and do not throw exceptions (although the configuration field is set twice). However, for more complex cases like [HDDS-13913](https://issues.apache.org/jira/browse/HDDS-13913), the effective configuration value that is set might be different than the configuration value to set (e.g. excluding SCM nodes that cannot be connected). The tests should also use `reconfigureProperty` instead of `reconfigurePropertyImpl`. Note that some reconfigures such as `OzoneManager#reconfOzoneSnapshotSSTFilteringServiceInterval` remains unchanged since changing it requires introducing more implementations. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-14016 ## How was this patch tested? CI (https://github.com/ivandika3/ozone/actions/runs/19723196924). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
