chungen0126 commented on PR #9383: URL: https://github.com/apache/ozone/pull/9383#issuecomment-3585054236
> @chungen0126 I think in these cases, parsing the value (e.g. `Integer#parseInt`) will throw `NumberFormatException` that will be translated to `ReconfigurationException` in `reconfigurePropertyImpl` and the configuration should remain unchanged. @ivandika3 You can keep your approach, but for me, a null check is better than throwing an exception. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
