adoroszlai commented on PR #9383: URL: https://github.com/apache/ozone/pull/9383#issuecomment-3585024119
Thanks @ivandika3 for updating the patch. > I have added support for listAllVolumeAllowed since it's simpler (although it requires duplicating the `Configuration#getBoolean` logic to prevent regression). > > As mentioned in the description, I decided to skip `OZONE_SNAPSHOT_SST_FILTERING_SERVICE_INTERVAL` since it requires extracting the `Configuration#getTimeDuration` which seems to be overkill. However, I'm OK if duplication is not an issue, or we can have some util class with static methods for `getTimeDuration` without needing to instantiate of the `Configuration` class. Sorry, I didn't realize the implementations depend on value sanitization in `Configuration`. I would prefer to keep the existing impl (revert a8d98b91faf12b895404c2e90b158c8f20a70c90), and address in follow-up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
