adoroszlai commented on code in PR #9373:
URL: https://github.com/apache/ozone/pull/9373#discussion_r2570769842
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManagerReport.java:
##########
@@ -72,9 +73,18 @@ public static ReplicationManagerReport fromProtobuf(
}
public ReplicationManagerReport() {
+ this(SAMPLE_LIMIT);
+ }
Review Comment:
On second look, this usage should be updated to get the actual limit from
the report:
https://github.com/apache/ozone/blob/ae799bd73c2bd10faa521a5f365cffc7556675ec/hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/hdds/scm/cli/container/ReportSubcommand.java#L107
For that, the limit needs to be added to the proto definition:
https://github.com/apache/ozone/blob/ae799bd73c2bd10faa521a5f365cffc7556675ec/hadoop-hdds/interface-client/src/main/proto/hdds.proto#L478-L482
and message:
https://github.com/apache/ozone/blob/ae799bd73c2bd10faa521a5f365cffc7556675ec/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManagerReport.java#L240
https://github.com/apache/ozone/blob/ae799bd73c2bd10faa521a5f365cffc7556675ec/hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManagerReport.java#L60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
