adoroszlai commented on code in PR #9373:
URL: https://github.com/apache/ozone/pull/9373#discussion_r2570796284
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/container/ReplicationManagerReport.java:
##########
@@ -72,9 +73,18 @@ public static ReplicationManagerReport fromProtobuf(
}
public ReplicationManagerReport() {
+ this(SAMPLE_LIMIT);
+ }
Review Comment:
It would be nice to update `TestReplicationManagerReport`, too:
1. check report's `sampleLimit` here:
https://github.com/apache/ozone/blob/ae799bd73c2bd10faa521a5f365cffc7556675ec/hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/scm/container/TestReplicationManagerReport.java#L157-L170
2. new test case for custom limit similar to `testSamplesAreLimited` (please
extract existing logic to a new method with parameters `report` and
`expectedSampleSize`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
