adoroszlai commented on code in PR #9373:
URL: https://github.com/apache/ozone/pull/9373#discussion_r2574026163
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -478,6 +478,7 @@ message ReplicationManagerReportProto {
required int64 timestamp = 1;
repeated KeyIntValue stat = 2;
repeated KeyContainerIDList statSample = 3;
+ required int32 sampleLimit = 4;
Review Comment:
Avoid `required` fields.
https://protobuf.dev/programming-guides/style/#required
```suggestion
optional int32 sampleLimit = 4 [default = 100];
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
