sreejasahithi commented on code in PR #9461:
URL: https://github.com/apache/ozone/pull/9461#discussion_r2598379395
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/StreamBlockInputStream.java:
##########
@@ -399,7 +403,7 @@ private ByteBuffer read(int length, boolean preRead) throws
IOException {
}
ByteBuffer readFromQueue() throws IOException {
- final ReadBlockResponseProto readBlock = poll(10, TimeUnit.SECONDS);
+ final ReadBlockResponseProto readBlock = poll(readTimeoutMs,
TimeUnit.SECONDS);
Review Comment:
Because readTimeoutMs is in milliseconds, you must pass
TimeUnit.MILLISECONDS so the timeout isn’t misinterpreted as seconds
```suggestion
final ReadBlockResponseProto readBlock = poll(readTimeoutMs,
TimeUnit.MILLISECONDS);
```
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java:
##########
@@ -281,6 +281,27 @@ public class OzoneClientConfig {
tags = ConfigTag.CLIENT)
private int maxConcurrentWritePerKey = 1;
+ @Config(key = "ozone.client.stream.read.pre-read-size",
+ defaultValue = "33554432",
+ type = ConfigType.LONG,
+ tags = {ConfigTag.CLIENT},
+ description = "Extra bytes to prefetch during streaming reads.")
+ private long streamReadPreReadSize = 32L << 20;
+
+ @Config(key = "ozone.client.stream.read.response-data-size",
+ defaultValue = "1048576",
+ type = ConfigType.INT,
+ tags = {ConfigTag.CLIENT},
+ description = "Chunk size of streaming read responses from datanodes.")
+ private int streamReadResponseDataSize = 1 << 20;
+
+ @Config(key = "ozone.client.stream.read.timeout",
+ defaultValue = "1000",
Review Comment:
The default value should be 10000 in order to match with the
ozone-default.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
