adoroszlai commented on code in PR #9461:
URL: https://github.com/apache/ozone/pull/9461#discussion_r2598519529
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java:
##########
@@ -281,6 +281,27 @@ public class OzoneClientConfig {
tags = ConfigTag.CLIENT)
private int maxConcurrentWritePerKey = 1;
+ @Config(key = "ozone.client.stream.read.pre-read-size",
+ defaultValue = "33554432",
+ type = ConfigType.LONG,
+ tags = {ConfigTag.CLIENT},
+ description = "Extra bytes to prefetch during streaming reads.")
+ private long streamReadPreReadSize = 32L << 20;
+
+ @Config(key = "ozone.client.stream.read.response-data-size",
+ defaultValue = "1048576",
+ type = ConfigType.INT,
+ tags = {ConfigTag.CLIENT},
+ description = "Chunk size of streaming read responses from datanodes.")
+ private int streamReadResponseDataSize = 1 << 20;
+
+ @Config(key = "ozone.client.stream.read.timeout",
+ defaultValue = "1000",
+ type = ConfigType.INT,
+ tags = {ConfigTag.CLIENT},
+ description = "Timeout in ms for receiving streaming read responses.")
+ private int streamReadTimeoutMs = 10_000;
Review Comment:
Plese use `Duration` instead of `int` and drop `Ms` from name.
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java:
##########
@@ -553,6 +574,18 @@ public void setStreamReadBlock(boolean streamReadBlock) {
this.streamReadBlock = streamReadBlock;
}
+ public long getStreamReadPreReadSize() {
+ return streamReadPreReadSize;
+ }
+
+ public int getStreamReadResponseDataSize() {
+ return streamReadResponseDataSize;
+ }
+
+ public int getStreamReadTimeoutMs() {
+ return streamReadTimeoutMs;
Review Comment:
Return `Duration` and drop `Ms` from name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
