adoroszlai commented on code in PR #9461:
URL: https://github.com/apache/ozone/pull/9461#discussion_r2615596091
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/StreamBlockInputStream.java:
##########
@@ -351,8 +371,8 @@ void checkError() throws IOException {
}
}
- ReadBlockResponseProto poll(int timeout, TimeUnit timeoutUnit) throws
IOException {
- final long timeoutNanos = timeoutUnit.toNanos(timeout);
+ ReadBlockResponseProto poll() throws IOException {
+ final long timeoutNanos = readTimeoutNanos;
Review Comment:
nit: remove `timeoutNanos` and use `readTimeoutNanos` directly.
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -693,7 +693,7 @@ public final class OzoneConfigKeys {
public static final String OZONE_CLIENT_ELASTIC_BYTE_BUFFER_POOL_MAX_SIZE =
"ozone.client.elastic.byte.buffer.pool.max.size";
public static final String
OZONE_CLIENT_ELASTIC_BYTE_BUFFER_POOL_MAX_SIZE_DEFAULT = "16GB";
-
+
Review Comment:
nit: please avoid whiitespace-only change
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
