errose28 opened a new pull request #2257: URL: https://github.com/apache/ozone/pull/2257
## What changes were proposed in this pull request? SCM HA has been merged in to the master branch before the upgrade framework. With the current implementation of SCM HA pre-finalize validation (which prevents the new feature from being used until the cluster is finalized) users who follow the Apache releases and those who incrementally pull from master will have different experiences when they get the upgrade framework: For users following official Ozone releases, the upgrade framework and SCM HA will land in the same release. SCM HA should not be allowed in pre-finalize so that these users can downgrade using the upgrade framework. This is currently how the validation action works. For users who pull from master and are already using SCM HA, the current pre-finalize validation will fail to start the SCM until they turn off SCM HA. The cluster must be finalized, and then SCM HA can be re-enabled. This may be surprising and inconvenient. To support both use cases, the SCM HA pre-finalize validation action should not fail if SCM HA was already being used before the upgrade. To check for this, we will check if there are ratis log entries when the action runs. SCM validation actions have been changed to run before the ratis server starts, so if there is a valid committed log index when the action runs, it must be from when SCM HA was used before an upgrade. ## What is the link to the Apache JIRA HDDS-5226 ## How was this patch tested? Due to more complex behavior, the existing unit test for the old action was replaced with an integration test. Since this feature will not be changing frequently, the test is ignored to save CI time, but can be run locally to verify this action if it needs to be modified. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
