errose28 commented on a change in pull request #2257:
URL: https://github.com/apache/ozone/pull/2257#discussion_r634860109
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java
##########
@@ -1158,6 +1158,8 @@ public String getDatanodeRpcPort() {
*/
@Override
public void start() throws IOException {
+ upgradeFinalizer.runPrefinalizeStateActions(scmStorageConfig, this);
Review comment:
Took a closer look and init actually cannot happen in a pre-finalized
cluster. SCM must already be inited for the cluster to be pre-finalized, and
running init again will cause an error in `Storage#setClusterId`. So we
shouldn't have to worry about ratis server being started in init for
pre-finalized clusters. In new clusters it is not a problem since there is
nowhere to downgrade to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
