hevinhsu commented on PR #9294: URL: https://github.com/apache/ozone/pull/9294#issuecomment-3663223056
Thanks @ivandika3 for the feedback. I’ll switch to using a list of `preCommit` handlers instead and address the remaining follow-up items over the weekend, as I’m a bit busy recently. Sorry for the delay. > we might be able to use Ratis `CheckedRunnable<IOException>` as the preCommit (similar to the Validator interface in `XceiverClientSpi`)? Afterwards, we can simply throw OS3Exception that will be automatically handled by OS3ExceptionMapper? Sorry, I may have misunderstood this point. I did try a similar approach while exploring the solution, but I ran into a limitation: `OS3Exception` does not extend `IOException`, so it cannot be thrown directly from a CheckedRunnable<IOException>. It’s possible that I’m not applying this pattern in the intended way. I also considered introducing a new `IOException` wrapper to carry an `OS3Exception`, but that felt somewhat over-engineered, so I decided not to go down that path for now. I’d appreciate any clarification on how you envisioned using `CheckedRunnable<IOException>` here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
