Gargi-jais11 commented on PR #9609: URL: https://github.com/apache/ozone/pull/9609#issuecomment-3727292081
It is also good if you add test cases for this part in `TestPipelinePlacementPolicy`, `TestRatisPipelineProvider` and `TestSCMNodeManager`. **1. RatisPipelineProvider** ``` Test flow: - Creates config without setting pipeline limit - Creates pipelines up to expected limit (6 pipelines with 10 nodes) - Verifies 7th pipeline creation throws SCMException - Validates error message mentions default limit of 2 Coverage: - Default value (2) used instead of 0 - Pipeline limit enforcement works - Error messages accurate ``` **2. PipelinePlacementPolicy** ``` Test flow: - Creates policy with config without limit set - Adds exactly 2 pipelines to test node (default limit) - Verifies node is filtered out when choosing nodes for new pipeline ``` **3. SCMNodeManager** ``` Test flow: - Creates node manager with config without limit set - Registers datanode with healthy volumes - Calls pipelineLimit() and verifies returns 2 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
