Gargi-jais11 commented on code in PR #9609:
URL: https://github.com/apache/ozone/pull/9609#discussion_r2680846612
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java:
##########
@@ -2055,6 +2055,29 @@ public void testScmRegisterNodeWithUpdatedIpAndHostname()
}
}
+ /**
+ * Test that pipelineLimit() uses the default value when the config is not
set.
+ */
+ @Test
+ public void testPipelineLimitDefaultIsTwoWhenUnset()
+ throws IOException, AuthenticationException {
+
+ // Creates node manager with config without limit set
+ OzoneConfiguration conf = getConf();
+ conf.unset(ScmConfigKeys.OZONE_DATANODE_PIPELINE_LIMIT);
+
+ try (SCMNodeManager nodeManager = createNodeManager(conf)) {
+
+ // Registers datanode with healthy volumes
+ DatanodeDetails dn = registerWithCapacity(nodeManager);
+
+ // Calls pipelineLimit() and verifies returns 2
+ int limit = nodeManager.pipelineLimit(dn);
+ assertEquals(ScmConfigKeys.OZONE_DATANODE_PIPELINE_LIMIT_DEFAULT, limit);
+ assertEquals(2, limit);
Review Comment:
This assertion is redundant. The first assertion itself is enough to check
that it picks the default value.
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java:
##########
@@ -2055,6 +2055,29 @@ public void testScmRegisterNodeWithUpdatedIpAndHostname()
}
}
+ /**
+ * Test that pipelineLimit() uses the default value when the config is not
set.
+ */
+ @Test
+ public void testPipelineLimitDefaultIsTwoWhenUnset()
Review Comment:
rename it as something more generic:`testUsesDefaultPipelineLimitWhenUnset()`
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/node/TestSCMNodeManager.java:
##########
@@ -2055,6 +2055,29 @@ public void testScmRegisterNodeWithUpdatedIpAndHostname()
}
}
+ /**
+ * Test that pipelineLimit() uses the default value when the config is not
set.
+ */
+ @Test
+ public void testPipelineLimitDefaultIsTwoWhenUnset()
+ throws IOException, AuthenticationException {
+
+ // Creates node manager with config without limit set
+ OzoneConfiguration conf = getConf();
+ conf.unset(ScmConfigKeys.OZONE_DATANODE_PIPELINE_LIMIT);
+
+ try (SCMNodeManager nodeManager = createNodeManager(conf)) {
+
+ // Registers datanode with healthy volumes
+ DatanodeDetails dn = registerWithCapacity(nodeManager);
+
+ // Calls pipelineLimit() and verifies returns 2
Review Comment:
```suggestion
// Calls pipelineLimit() and verifies returns default value
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
