szetszwo commented on code in PR #9609:
URL: https://github.com/apache/ozone/pull/9609#discussion_r2683002125
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java:
##########
@@ -195,8 +195,9 @@ public SCMNodeManager(
this.numPipelinesPerMetadataVolume =
conf.getInt(ScmConfigKeys.OZONE_SCM_PIPELINE_PER_METADATA_VOLUME,
ScmConfigKeys.OZONE_SCM_PIPELINE_PER_METADATA_VOLUME_DEFAULT);
- String dnLimit = conf.get(ScmConfigKeys.OZONE_DATANODE_PIPELINE_LIMIT);
- this.heavyNodeCriteria = dnLimit == null ? 0 : Integer.parseInt(dnLimit);
+ this.heavyNodeCriteria = conf.getInt(
Review Comment:
The existing field name `heavyNodeCriteria` is quite creative but unclear
what does it mean. Could you rename it to `datanodePipelineLimit`?
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/RatisPipelineProvider.java:
##########
@@ -82,9 +82,9 @@ public RatisPipelineProvider(NodeManager nodeManager,
this.pipelineNumberLimit = conf.getInt(
ScmConfigKeys.OZONE_SCM_RATIS_PIPELINE_LIMIT,
ScmConfigKeys.OZONE_SCM_RATIS_PIPELINE_LIMIT_DEFAULT);
- String dnLimit = conf.get(ScmConfigKeys.OZONE_DATANODE_PIPELINE_LIMIT);
- this.maxPipelinePerDatanode = dnLimit == null ? 0 :
- Integer.parseInt(dnLimit);
+ this.maxPipelinePerDatanode = conf.getInt(
Review Comment:
Let's also rename it to `datanodePipelineLimit`. So it is easier to tell
that they are the same thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
