devabhishekpal commented on code in PR #9584:
URL: https://github.com/apache/ozone/pull/9584#discussion_r2716201827
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/PendingDeletionEndpoint.java:
##########
@@ -56,15 +63,20 @@ public PendingDeletionEndpoint(
}
@GET
- public Response getPendingDeletionByComponent(@QueryParam("component")
String component) {
+ public Response getPendingDeletionByComponent(
+ @QueryParam("component")
+ String component,
+ @QueryParam("limit")
+ int limit
+ ) {
if (component == null || component.isEmpty()) {
return Response.status(Response.Status.BAD_REQUEST)
.entity("component query parameter is required").build();
}
Review Comment:
We do the less than 1 check in handleDatanodeMetrics:
```
if (limit < 1) {
return Response.status(Response.Status.BAD_REQUEST)
.entity("Limit query parameter must be at-least 1").build();
}
```
I have modified the code in the latest patch to account for the null limit
and return the whole list in that case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
