devabhishekpal commented on code in PR #9584:
URL: https://github.com/apache/ozone/pull/9584#discussion_r2718549815
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/DataNodeMetricsService.java:
##########
@@ -294,16 +300,23 @@ private void resetState() {
totalNodesFailed = 0;
}
- public DataNodeMetricsServiceResponse getCollectedMetrics() {
+ public DataNodeMetricsServiceResponse getCollectedMetrics(Integer limit) {
Review Comment:
But if we are not sure of the worst case scenario for number of DNs this
might cause issues with sorting and slicing for a very large dataset. If it's
in hundreds or thousands maybe it'll still perform well, but if this data is
expanded to include other properties and it is thousands of nodes I think the
browser might not be able to handle it properly.
Perhaps we can use something similar to infinite scroll instead of limit,
but for sorting I'd prefer if it is sorted from the backend itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
