priyeshkaratha commented on code in PR #9584:
URL: https://github.com/apache/ozone/pull/9584#discussion_r2717712413
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/DataNodeMetricsService.java:
##########
@@ -294,16 +300,23 @@ private void resetState() {
totalNodesFailed = 0;
}
- public DataNodeMetricsServiceResponse getCollectedMetrics() {
+ public DataNodeMetricsServiceResponse getCollectedMetrics(Integer limit) {
Review Comment:
@devmadhuu I was thinking about whether we should implement sorting and
fetching the top X results in the backend API, or move this logic to the
frontend. Since we rely on JMX, we have to fetch all the data from JMX before
we can perform any sorting. Because of this, applying sorting or limits in the
backend does not provide any performance benefit—it only reduces the response
size.
Given this, would it make more sense to move the sorting logic (based on
pending deletion data) to the frontend?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
