echonesis commented on PR #9689: URL: https://github.com/apache/ozone/pull/9689#issuecomment-3850837183
> > Before this change, both directories were auto-created in SCMSnapshotProvider constructor ... > > @echonesis , thanks for the info. For now, let's add the auto-create only for upgrade case but not inside `initializeRatis(..)` since `initializeRatis(..)` is also used in the non-upgrade cases. Would it work? Yes, that works. I'll move the auto-create logic to the upgrade case instead of `initializeRatis()`. One clarification: should we still plan for a `--upgrade` option in a follow-up JIRA to make this explicit, or is auto-create in the upgrade path acceptable as a long-term solution? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
