ChenSammi commented on code in PR #9363:
URL: https://github.com/apache/ozone/pull/9363#discussion_r2781254869
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -917,6 +917,68 @@ message SnapshotDiffJobProto {
optional double keysProcessedPct = 13;
}
+/**
+ * Per request type entities to hold arguments
+ * captured for CompletedRequestInfo
+ */
+message CreateVolumeOperationArgs {
+}
+
+message DeleteVolumeOperationArgs {
+}
+
+message CreateBucketOperationArgs {
+}
+
+message DeleteBucketOperationArgs {
+}
+
+message CreateKeyOperationArgs {
+}
+
+message RenameKeyOperationArgs {
+ required string toKeyName = 1;
+}
+
+message DeleteKeyOperationArgs {
+}
+
+message CommitKeyOperationArgs {
+}
+
+message CreateDirectoryOperationArgs {
+}
+
+message CreateFileOperationArgs {
+ required bool isRecursive = 2;
+ required bool isOverwrite = 3;
+}
+
+
+/**
+ * CompletedRequestInfo table entry
+ */
+message CompletedRequestInfo {
+
+ optional int64 trxLogIndex = 1;
Review Comment:
My initial suggestion is to change "optional" to "required" for trxLogIndex,
since I saw there is required field in the same data structure, and other new
structures in this patch. I assume this patch follows the proto2 rule.
I'm fine with pure proto2, or pure proto3 style, but not a mixed one. So if
proto3 is preferred, follow the proto3 rule, replace all newly added required
fields with optional, this is my current change suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
