sravani-revuri commented on code in PR #10056:
URL: https://github.com/apache/ozone/pull/10056#discussion_r3052565772
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java:
##########
@@ -253,8 +255,9 @@ public String getNamespace() {
datanodeDetails.setSetupTime(Time.now());
datanodeDetails.setRevision(
HddsVersionInfo.HDDS_VERSION_INFO.getRevision());
- TracingUtil.initTracing(
- "HddsDatanodeService." + datanodeDetails.getID(), conf);
+ tracingServiceName = "HddsDatanodeService." + datanodeDetails.getID();
+ TracingConfig tracingConfig = conf.getObject(TracingConfig.class);
+ TracingUtil.initTracing(tracingServiceName, conf);
Review Comment:
I have added TracingReconfigurationCallback in hdds-server-framework so it
can implement ReconfigurationChangeCallback to avoid cyclic dependency . Is
this the right approach, or is there a better way you'd suggest to structure
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
