adoroszlai commented on code in PR #10056:
URL: https://github.com/apache/ozone/pull/10056#discussion_r3056108242
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java:
##########
@@ -357,6 +361,8 @@ private StorageContainerManager(OzoneConfiguration conf,
scmHANodeDetails = SCMHANodeDetails.loadSCMHAConfig(conf,
scmStorageConfig);
configuration = conf;
+ tracingConfig = conf.getObject(TracingConfig.class);
+ TracingUtil.initTracing("StorageContainerManager", tracingConfig);
Review Comment:
Can call `TracingReconfigurationCallback.init` here and use callback below.
Let's move tracing init a bit up, after `Objects.requireNonNull` checks, to
cover more initial operations.
Also, a small unrelated improvement: please merge assignment of
`configuration` with the corresponding `requireNonNull` check:
```java
configuration = Objects.requireNonNull(conf, "configuration cannot be null");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
