adoroszlai commented on code in PR #10056:
URL: https://github.com/apache/ozone/pull/10056#discussion_r3056964596
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java:
##########
@@ -351,12 +353,15 @@ private StorageContainerManager(OzoneConfiguration conf,
super(HddsVersionInfo.HDDS_VERSION_INFO);
Objects.requireNonNull(configurator, "configurator cannot be null");
- Objects.requireNonNull(conf, "configuration cannot be null");
+ configuration = Objects.requireNonNull(conf, "configuration cannot be
null");
// It is assumed the scm --init command creates the SCM Storage Config.
+ TracingConfig tracingConfig = configuration.getObject(TracingConfig.class);
+ TracingReconfigurationCallback tracingReconfigurationCallback =
+ TracingReconfigurationCallback.init("StorageContainerManager",
tracingConfig);
scmStorageConfig = new SCMStorageConfig(conf);
Review Comment:
nit: please keep the comment and statement together
```suggestion
TracingConfig tracingConfig =
configuration.getObject(TracingConfig.class);
TracingReconfigurationCallback tracingReconfigurationCallback =
TracingReconfigurationCallback.init("StorageContainerManager",
tracingConfig);
// It is assumed the scm --init command creates the SCM Storage Config.
scmStorageConfig = new SCMStorageConfig(conf);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
