amaliujia commented on code in PR #10439:
URL: https://github.com/apache/ozone/pull/10439#discussion_r3360284831
##########
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBufferPool.java:
##########
@@ -94,14 +85,12 @@ private void
assertAllocationBlockedUntilReleased(BufferPool pool, Deque<ChunkBu
releaser.start();
allocator.join();
assertEquals(toRelease, allocated.get());
- assertTrue(logCapturer.getOutput().contains("Allocation needs to wait the
pool is at capacity"));
Review Comment:
I think we are losing testing coverage if you remove this line.
We might can do a
```
assertTrue(pool.allocated.size() == pool.capacity)
allocated.set(pool.allocateBuffer(0));
```
[above](https://github.com/apache/ozone/pull/10439/changes#diff-e42410e41f0e7d2b824f6ad6c1461d9f85da655e0b862bf149df60d0d8ccc488R66-R67)
However I am not completely sure.
To be safe, we can keep this type of verification. Other removals over
LOG_DEBUG look ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
