yandrey321 commented on code in PR #10439:
URL: https://github.com/apache/ozone/pull/10439#discussion_r3363487379


##########
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBufferPool.java:
##########
@@ -94,14 +85,12 @@ private void 
assertAllocationBlockedUntilReleased(BufferPool pool, Deque<ChunkBu
     releaser.start();
     allocator.join();
     assertEquals(toRelease, allocated.get());
-    assertTrue(logCapturer.getOutput().contains("Allocation needs to wait the 
pool is at capacity"));

Review Comment:
   I'd avoid validation through log messages and prefer to do it via actual 
state check



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to