amaliujia commented on code in PR #10439:
URL: https://github.com/apache/ozone/pull/10439#discussion_r3366355780
##########
hadoop-hdds/client/src/test/java/org/apache/hadoop/hdds/scm/storage/TestBufferPool.java:
##########
@@ -59,6 +59,8 @@ private void assertAllocationBlockedUntilReleased(BufferPool
pool, Deque<ChunkBu
// As the pool is full, allocation will need to wait until a buffer is
released.
assertFull(pool);
+ assertEquals(buffers.size(), pool.getAllocatedBuffers().size());
Review Comment:
Looks like this addition verifies if there is any new allocation happened
after a batch of buffer allocations through the pool.
Can we name this assertion as`assertNoBuffersChangeInPool(buffersSize,
pool)`? This might have better readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
