sodonnel commented on code in PR #10543:
URL: https://github.com/apache/ozone/pull/10543#discussion_r3437728441
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -1150,14 +1150,16 @@ public ReplicationManagerReport
getReplicationManagerReport() {
return scm.getReplicationManager().getContainerReport();
}
+ /*
+ * This command is deprecated and is retained for backward compatibility. It
no longer finalizes SCM
+ * as the process is driven from OM which will trigger the SCM finalize
process.
+ */
@Override
@Deprecated
- public StatusAndMessages finalizeScmUpgrade(String upgradeClientID) throws
- IOException {
+ public StatusAndMessages finalizeScmUpgrade(String upgradeClientID) {
if (!scm.getVersionManager().needsFinalization()) {
return new StatusAndMessages(ALREADY_FINALIZED, Collections.emptyList());
}
- finalizeUpgrade();
return new StatusAndMessages(STARTING_FINALIZATION,
Collections.emptyList());
Review Comment:
> The enum value is correct since the client requires this for the command
to succeed, which is required by old scripts or clients which will then move on
to OM automatically.
Are you saying we should always return ALREADY_FINALIZED, otherwise the old
script will be stuck waiting for SCM to complete, which will never happen as
this is a NOOP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
