octachoron commented on code in PR #10543:
URL: https://github.com/apache/ozone/pull/10543#discussion_r3437873368
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java:
##########
@@ -1150,14 +1150,16 @@ public ReplicationManagerReport
getReplicationManagerReport() {
return scm.getReplicationManager().getContainerReport();
}
+ /*
+ * This command is deprecated and is retained for backward compatibility. It
no longer finalizes SCM
+ * as the process is driven from OM which will trigger the SCM finalize
process.
+ */
@Override
@Deprecated
- public StatusAndMessages finalizeScmUpgrade(String upgradeClientID) throws
- IOException {
+ public StatusAndMessages finalizeScmUpgrade(String upgradeClientID) {
if (!scm.getVersionManager().needsFinalization()) {
return new StatusAndMessages(ALREADY_FINALIZED, Collections.emptyList());
}
- finalizeUpgrade();
return new StatusAndMessages(STARTING_FINALIZATION,
Collections.emptyList());
Review Comment:
Based on a quick scan of the code, I'm not sure if we have tests that catch
this case (like when we first tried to make OM finalize a no-op before there
was any other trigger), but that would be quite fortunate - the interesting
point where a human operator may get confused is when a test times out waiting
for the success state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
