sodonnel commented on code in PR #10543:
URL: https://github.com/apache/ozone/pull/10543#discussion_r3442120299
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/server/TestSCMClientProtocolServer.java:
##########
@@ -62,17 +69,16 @@
* servicing commands from the scm client.
*/
public class TestSCMClientProtocolServer {
- private SCMClientProtocolServer server;
- private StorageContainerManager scm;
- private StorageContainerLocationProtocolServerSideTranslatorPB service;
- private SCMSafeModeManager mockSafeModeManager;
-
- @BeforeEach
- void setUp(@TempDir File testDir) throws Exception {
+ private static SCMClientProtocolServer server;
Review Comment:
Test changes were because each test in this call was taking 3 seconds due to
start and stopping the RPC server for each test. Now the first takes a few
seconds and the others are 10ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
