sodonnel commented on a change in pull request #2401:
URL: https://github.com/apache/ozone/pull/2401#discussion_r669500437
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/BucketArgs.java
##########
@@ -228,12 +269,23 @@ public Builder() {
return this;
}
+ public BucketArgs.Builder setEcReplicationConfig(
+ ECReplicationConfig ecReplConfig) {
+ ecReplicationConfig = ecReplConfig;
+ return this;
+ }
+
/**
* Constructs the BucketArgs.
* @return instance of BucketArgs.
*/
public BucketArgs build() {
+ if(ecReplicationConfig!=null){
+ return new BucketArgs(versioning, storageType, acls, metadata,
+ bucketEncryptionKey, sourceVolume, sourceBucket, quotaInBytes,
+ quotaInNamespace, ecReplicationConfig);
+ }
Review comment:
If we just add a parameter to the original constructor, we can just pass
ecReplicationConfig, and if it is null, it doesn't matter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
