sodonnel commented on a change in pull request #2401:
URL: https://github.com/apache/ozone/pull/2401#discussion_r669506125



##########
File path: 
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmBucketInfo.java
##########
@@ -554,6 +638,10 @@ public static OmBucketInfo getFromProtobuf(BucketInfo 
bucketInfo) {
         .setQuotaInBytes(bucketInfo.getQuotaInBytes())
         .setUsedNamespace(bucketInfo.getUsedNamespace())
         .setQuotaInNamespace(bucketInfo.getQuotaInNamespace());
+    if (bucketInfo.hasEcReplicationConfig()) {
+      obib.setEcReplicationConfig(
+          new ECReplicationConfig(bucketInfo.getEcReplicationConfig()));
+    }
     if (bucketInfo.hasObjectID()) {
       obib.setObjectID(bucketInfo.getObjectID());
     }

Review comment:
       There are a few other methods in OmBucketInfo I think need updated to 
account for the new ECReplicationType field. Eg:
   
   `toString()`
   `equals()` - seems to take all fields into account at the moment.
   `getObjectInfo()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to